Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken deleteActionHandler in shadow API #69

Closed
johnhopwood opened this issue Jan 13, 2017 · 1 comment
Closed

Fix for broken deleteActionHandler in shadow API #69

johnhopwood opened this issue Jan 13, 2017 · 1 comment

Comments

@johnhopwood
Copy link

The deleteActionHandler mechanism does not invoke the callback when shadows are deleted. To fix, make the deleteAcceptedTopic buffer static in aws_iot_shadow.c:

static char deleteAcceptedTopic[MAX_SHADOW_TOPIC_LENGTH_BYTES];

Currently, the handler is not found by _aws_iot_mqtt_internal_deliver_message b/c the topic was created on the stack.

https://github.com/aws/aws-iot-device-sdk-embedded-C/blob/master/src/aws_iot_shadow.c#L92

@chaurah
Copy link
Contributor

chaurah commented Jan 13, 2017

Hi @johnhopwood,
Thank you for pointing this out. I have added a bugfix to our list of tasks for the next SDK release. I will update this issue and close when the release is out.
Please do let us know if you find any more issues with the SDK or have any further suggestions. Thank you for using AWS IoT.

Rahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants