Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MQTT header constructing and parsing #59

Closed
wants to merge 1 commit into from

Conversation

lkaino
Copy link
Contributor

@lkaino lkaino commented Dec 8, 2016

Bit fields must not be used in communication protocol frame parsing. See http://stackoverflow.com/questions/1490092/c-c-force-bit-field-order-and-alignment.

The bit-fields used in AWS C library caused issues in PowerPC target I'm using.

This might not be the most beautiful way to fix it, but it works. Tested on x86 and PowerPC architectures.

@chaurah
Copy link
Contributor

chaurah commented Dec 8, 2016

Hi @lkaino,
Thank you for submitting this pull request. We are already working on removing these bit-fields for the next release of the SDK. This change will be very useful towards that goal. Our usual process for including pull requests is that we include the change in the next release of the SDK after merging it internally. I will update and close this issue when that release is out.

Please do let us know if you have further suggestions. Thank you for using AWS IoT.

Rahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants