Split the PubSub sample down into smaller samples #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
reviewed
Mar 23, 2022
samples/WebsocketConnect/src/main/java/websocketconnect/WebsocketConnect.java
Outdated
Show resolved
Hide resolved
...iderConnect/src/main/java/x509credentialsproviderconnect/X509CredentialsProviderConnect.java
Outdated
Show resolved
Hide resolved
* Added PubSub sample back to codebuild tests * Fixed typos and little code mistakes * Simplified connection samples to use Utility functions in CommandLineUtils * Added function for the connection/disconnection code that is the same across all connection samples and added it to CommandLineUtils for reuse across samples
|
Thanks for the review! I adjusted the code accordingly 👍 |
|
You'll need to update the new WindowsCertPubSub sample too (it just landed in |
|
Awesome, will do! |
…er connect samples
|
Updated the WindowsCertPubSub sample so it is a connect sample and made (really minor) changes so it is similar to the other connect samples 👍 |
sbSteveK
approved these changes
Apr 1, 2022
|
Thanks for the review! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Splits the pub-sub sample down into multiple smaller samples that connect using a single method, rather than having one large pub-sub sample that can connect with multiple methods. This makes it easier for users to see how to connect using each method.
Also adds helper functions to the commandLineUtils function for making a MQTT connection without needing to manually set it up, removing the MQTT connection code duplication across samples and instead allowing them to focus on showing the key feature of the sample.
Finally, this PR also refactors the samples a little to make them a bit more compact and easier to follow.
Edit: This PR has an issue with references not being fully released, causing the samples that use the MQTT builder to pause for about a minute. This issue should be fixed by the following PR: awslabs/aws-crt-java#459
(Will need to be tested again once the PR is merged)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.