Update Greengrass V2 IPC models #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
Jun 23, 2022
| @Expose( | ||
| serialize = true, | ||
| deserialize = true | ||
| ) | ||
| @Deprecated |
There was a problem hiding this comment.
Is this supposed to be deprecated? I didn't noticed deprecation warnings on the other PRs (though maybe I missed it?)
| private Optional<String> topicName; | ||
|
|
||
| public SubscribeToTopicResponse() { | ||
| this.topicName = Optional.empty(); | ||
| } | ||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
Is this supposed to be deprecated? I didn't noticed deprecation warnings on the other PRs (though maybe I missed it?)
| public String getTopicName() { | ||
| if (topicName.isPresent()) { | ||
| return topicName.get(); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
Is this supposed to be deprecated? I didn't noticed deprecation warnings on the other PRs (though maybe I missed it?)
| public void setTopicName(final String topicName) { | ||
| this.topicName = Optional.ofNullable(topicName); | ||
| } | ||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
Is this supposed to be deprecated? I didn't noticed deprecation warnings on the other PRs (though maybe I missed it?)
|
Thank you for the changes! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.