Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration guide from V1 SDK #533

Merged
merged 61 commits into from
Feb 14, 2024
Merged

Add migration guide from V1 SDK #533

merged 61 commits into from
Feb 14, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Jan 24, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod marked this pull request as ready for review January 25, 2024 19:32
@sbSteveK
Copy link
Contributor

Let's link to the migration guide somewhere. Either in the FAQ doc, under the Getting Help section in the main README, or both.

sbSteveK
sbSteveK approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Implement (or don't) trivial changes and ship.

@sfod sfod merged commit aeec7ff into main Feb 14, 2024
24 checks passed
@sfod sfod deleted the add-migration-guide branch February 14, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiazhvera xiazhvera xiazhvera left review comments

@alfred2g alfred2g alfred2g left review comments

@sbSteveK sbSteveK sbSteveK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfod @sbSteveK @xiazhvera @alfred2g @sfodagain @liunamz-aws