Skip to content

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Sep 24, 2025

Issue #, if available:

Description of changes:

  • Add cipher preference option in MQTT builders

TODO!!!!!
The PR should wait for awslabs/aws-crt-python#684 get merge and released.
And update awscrt version afterwards.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want cipher suite on the static builder functions or as a separate API?

@xiazhvera
Copy link
Contributor Author

Do we want cipher suite on the static builder functions or as a separate API?

Python SDK static builder function directly return a mqtt5 client / mqtt3 connection. We don't really have a way to add a separate API for builder.

@xiazhvera xiazhvera changed the title [WIP] Add cipher suite option in mqtt builder Add cipher preference option in builder Sep 29, 2025
@xiazhvera xiazhvera marked this pull request as ready for review September 29, 2025 23:14
@sfod
Copy link
Contributor

sfod commented Oct 20, 2025

cipher_pref documentation should be added to top of each builder file, in the Optional Keyword Arguments section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants