fix: WindowsError keyword is undefined on non-Windows platforms #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindowsError is a subclass of `OSError`. It is defined and raised only in Windows. Hence the exception statement will return a `WindowsError keyword is undefined` in other platforms.
jfuss
reviewed
May 31, 2019
aws_lambda_builders/utils.py
Outdated
| # Let's try to copy the directory metadata from source to destination | ||
| shutil.copystat(source, destination) | ||
| except WindowsError as ex: # pylint: disable=undefined-variable | ||
| except OSError as ex: # pylint: disable=undefined-variable |
Contributor
There was a problem hiding this comment.
Do we still need the pytlint disable here?
Contributor
|
Can you add context on where you encountered this? will help for why this was fixed. |
Contributor
Author
|
sriram-mv
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindowsError is a subclass of
OSError. It is defined and raised onlyin Windows. Hence the exception statement will return a
WindowsError keyword is undefinedin other platforms.EDIT: Usually this error is encountered when
CodeUri: /folder/does/not/exist. The builder tries to copy the files and fails because the path does not exist. On Windows, the exception handler works, but on Mac/Linux Python interpreter does not find the variableWindowsErrorand crashes. So it leads to a vagueWindowsErroron Mac/Linux.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.