-
Notifications
You must be signed in to change notification settings - Fork 152
Ignore .git files #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore .git files #120
Conversation
This causes issues on Windows machines due to file handles not being released
|
Thanks for this change! is there a unit test you could write for this as well? |
|
I've had the same issue on Windows 10 and implementing the fix locally does resolve the problem. |
|
@matt-lumer .git files are ignored since the last release. You should cancel your pull request. |
|
@khamaileon Can you show me where this change was made? I checked this source file and found JavaMavenWorkflow:MavenCopyArtifacts failed sam --version |
|
@matt-lumer Sorry mate, I was looking at the python builder. There should be a way to globally include or exclude files inside serverless.yml. It would solve a lot of packaging issues.. |
|
Np, I got all excited :) Yes ultimately I agree it would be nice to have configuration through the files and not buried within the app. Java really suffers from having a subdirectory so I'll get on the unit test and hopefully we'll have this promoted |
|
@thesriram I added the unit test, sorry for such a long delay. Can you review? |
|
Thanks for the contribution! |
|
@awood45 Thanks so much!! |
This causes issues on Windows machines due to file handles not being released
Issue #, if available:
Description of changes:
Added .git to the list of excluded files, similar to the python one which has additional files.
.git causes "WindowsError: [Error 5] Access is denied: c:\temp\.git\objects\*"
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.