fix: change the pip runner string based on a pip version check #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sanathkr
previously approved these changes
Oct 17, 2019
- if pip version is less than 19.3, choose to run main directly as its a function, whereas with pip versions starting with 19.3, execute the function `main` inside the pip.main module
sriram-mv
force-pushed
the
python_pip_builder_pip19.3_fix
branch
from
0f359f3 to
9133418
Compare
awood45
approved these changes
Oct 17, 2019
stealthycoin
approved these changes
Oct 17, 2019
sanathkr
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip.maindirectly as its afunction, whereas with pip versions starting with 19.3, execute the
function
maininside the pip.main moduleIssue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.