feat:Add Go Modules Debug Build Flags #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to do IDE debugging of Go functions.
Contributor
Author
|
My local functional tests (which should be unrelated to my change) are failing in a way that seems unrelated, so watching AppVeyor closely. |
c2tarun
reviewed
Jan 20, 2020
c2tarun
left a comment
c2tarun
left a comment
There was a problem hiding this comment.
PR title to semantic messaging format ;)
| runtime_path = self.binaries[self.LANGUAGE].binary_path | ||
| cmd = [runtime_path, "build", "-o", output_path, source_dir_path] | ||
| cmd = [runtime_path, "build"] | ||
| if self.mode and self.mode.lower() == BuildMode.DEBUG: |
There was a problem hiding this comment.
Are we sure that BuildMode.DEBUG is always lower? I would suggest to make it BuildMode.DEBUG.lower() as well.
Contributor
Author
There was a problem hiding this comment.
Following a pattern from the .NET builder, so the aws_lambda_builders/workflow.py::BuildMode enum values are contracted to be lower case, but input is not.
c2tarun
previously approved these changes
Jan 20, 2020
jfuss
previously approved these changes
Jan 21, 2020
When you update a test, try updating the appropriate code. This is why we have automated test harnesses.
jfuss
approved these changes
Jan 21, 2020
awood45
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to do IDE debugging of Go functions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.