fix: Regex for getting aws_lambda_builders version #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
I noticed that the version of Lambda Builders was the whole file. This gets tracked back to when we added
This did not happen before because the
__version__was a string in single quotes andRPC_PROTOCOL_VERSIONwas double quotes. 557214b#diff-eeb75f3f96c23565c44aae048349b2a3 Our regex at that time, assumed only version was the only thing in single quotes in the file (aws_lambda_builders/__init__.py). When we updated to standardize strings to be all double quotes with black, I update this regex assuming the regex was already taking into account many things in the file. This PR fixes that assumption so that the version is only the__version__value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.