-
Notifications
You must be signed in to change notification settings - Fork 152
fix integration test for mismatched python version #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e243eab
fix integration test for mismatched python version
jpassaro f21bab8
use cross-version compatible assertion
jpassaro 54810f1
lint/black fix
jpassaro 8cc3baf
Merge branch 'develop' into integration-test-fix
mndeveci 9cdacc5
Merge branch 'develop' into integration-test-fix
CoshUS ecbef63
Merge branch 'develop' into integration-test-fix
moelasmar bc7ea5a
Merge branch 'develop' into integration-test-fix
mildaniel d6c82b6
Merge branch 'develop' into integration-test-fix
mndeveci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||||
| import os | ||||||
| import shutil | ||||||
| import six | ||||||
| import sys | ||||||
| import platform | ||||||
| import tempfile | ||||||
|
|
@@ -137,7 +138,15 @@ def test_mismatch_runtime_python_project(self): | |||||
| runtime=self.runtime_mismatch[self.runtime], | ||||||
| ) | ||||||
| except WorkflowFailedError as ex: | ||||||
| self.assertIn("Binary validation failed", str(ex)) | ||||||
| # handle both e.g. missing /usr/bin/python2.7 and situation where | ||||||
| # python2.7 does not have pip installed (as is the case in some | ||||||
| # Mac environments) | ||||||
| ex_s = str(ex) | ||||||
| if ( | ||||||
| "Binary validation failed" not in ex_s | ||||||
| and "pip executable not found in your python environment" not in ex_s | ||||||
| ): | ||||||
| six.raise_from(AssertionError("Unexpected exception"), ex) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Consider not using
Suggested change
|
||||||
|
|
||||||
| def test_runtime_validate_python_project_fail_open_unsupported_runtime(self): | ||||||
| with self.assertRaises(WorkflowFailedError): | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Consider not using
six