Adding wheel dependency for python_pip packager #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
changed the title
This was referenced Nov 22, 2018
sanathkr
added a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#31 and #29
Description of changes:
python_pippackager depends on setuptools and wheel to be available in environment. Ideally we would install these requirements into the target Python version we build, but to help the 80% of the case where they had pip installed this library, I am including the dependency directly here.This also helps when you install the library inside a Docker container that uses a Python version that doesn't come with wheel.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.