Skip to content

fix: log results of make build #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mildaniel merged 3 commits into from
Apr 14, 2022
Merged

fix: log results of make build #351

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f2023a
fix: log results of make build
calabrla Apr 6, 2022
2576e03
Merge branch 'develop' into make-log
calabrla Apr 12, 2022
ae6a8ce
adding comment that logging to INFO here is the exception not the rule
calabrla Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions aws_lambda_builders/workflows/custom_make/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ def run(self, args, env=None, cwd=None):

out, err = p.communicate()

# Typically this type of information is logged to DEBUG, however, since the Make builder
# can be different per customer's use case, it is helpful to always log the output so
# developers can diagnose any issues.
LOG.info(out.decode("utf8").strip())
Copy link
Contributor

@mndeveci mndeveci Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also think about printing err output as well?

Copy link
Contributor Author

@calabrla calabrla Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it sufficient that the err is raised by the MakeExecutionError if the return code is not 0 in lines 89-90?


if p.returncode != 0:
raise MakeExecutionError(message=err.decode("utf8").strip())

Expand Down