feat: Esbuild Generic Command Builder #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
commented
Jul 6, 2022
| self._run_external_esbuild_in_nodejs(script) | ||
| return | ||
| if self._should_bundle_deps_externally(): | ||
| esbuild_command.build_with_no_dependencies() |
Contributor
Author
There was a problem hiding this comment.
Instead of calling the external Node.js plugin to handle this, which would require us to update the Node.js template each time, we just make a list of all dependencies in the package.json file and set those to external.
mndeveci
reviewed
Jul 6, 2022
mndeveci
approved these changes
Jul 7, 2022
mildaniel
commented
Jul 7, 2022
qingchm
approved these changes
Jul 8, 2022
Contributor
qingchm
left a comment
qingchm
left a comment
There was a problem hiding this comment.
Notes from peer review session: since for other bundler configs we only add in default ones if the flag is not present, we discussed the possibility of having to handle duplicate external flags when building with no dependencies. A quick check on if duplicate arguments cause any unexpected behaviour would be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
These changes create a generic command builder to handle the three types of esbuild flags that are part of the esbuild CLI API. This PR also removes the workaround of calling a separate Node.js script to mark all dependencies as external, instead we go through the
package.jsonand mark all dependencies there as external individually.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.