test: Add GH Actions #410
Merged
test: Add GH Actions #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-builders into github-actions-jobs
…-builders into github-actions-jobs
mndeveci
reviewed
Nov 29, 2022
.github/workflows/build.yml
Outdated
| python-version: ${{ matrix.python }} | ||
| - uses: actions/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '^3.1' |
Contributor
There was a problem hiding this comment.
Lambda supports ruby2.7, so should we setup that version for the tests as well?
Contributor
|
This is exciting! 🥳 |
mndeveci
approved these changes
Nov 29, 2022
hawflau
approved these changes
Nov 29, 2022
Contributor
hawflau
left a comment
hawflau
left a comment
There was a problem hiding this comment.
approved with a small comment
| python: | ||
| - "3.7" | ||
| - "3.8" | ||
| - "3.9" |
Contributor
There was a problem hiding this comment.
nit: shall we add "3.10" as well?
Contributor
Author
There was a problem hiding this comment.
I think this might result in exceeding the limit of jobs/pr... Might need a separate job that does a smoke test with all versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating CI jobs from AppVeyor to GitHub actions.
This PR parallelizes runtime integration tests so that they can complete faster (from ~22 minutes to ~9 minutes).
It also parameterizes the runtime tests so that we can test multiple dependency versions per runtime (e.g. we're testing both npm 8.x and 9.x for Node.js-based runtimes).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.