fix: Copy over shrinkwrap if it exists #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
approved these changes
Nov 28, 2022
Comment on lines
116
to
123
| [False, False, False], | ||
| [True, False, False], | ||
| [False, True, False], | ||
| [True, True, False], | ||
| [False, False, True], | ||
| [True, False, True], | ||
| [False, True, True], | ||
| [True, True, True], |
Contributor
There was a problem hiding this comment.
nit: if this is all the combination of these 3 params, we can also write it like this;
@parameterized.expand(
itertools.product([True, False], [True, False], [True, False])
)
Contributor
Author
There was a problem hiding this comment.
Oh cool, let me try that, thanks!
torresxb1
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
npm 9.xno longer packs thenpm-shrinkwrap.jsonso we need to do it ourselves to respect this file during installation, similarly to how to copy over thepackage-lock.json.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.