feat: add new parameter to build in source and pass parameter into workflows #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torresxb1
commented
Dec 15, 2022
| architecture=params.get("architecture", X86_64), | ||
| is_building_layer=params.get("is_building_layer", False), | ||
| experimental_flags=params.get("experimental_flags", []), | ||
| build_in_source=params.get("build_in_source", None), |
Contributor
Author
There was a problem hiding this comment.
default is None because some workflows are built in source by default and some are not. Planning to leave it up to each workflow to handle defaults.
torresxb1
commented
Dec 15, 2022
mildaniel
approved these changes
Dec 15, 2022
lucashuy
approved these changes
Dec 15, 2022
sriram-mv
approved these changes
Dec 15, 2022
…lders into in-source-entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
(implementation for each workflow will come in subsequent PRs)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.