Skip to content

fix: Fix failing esbuild integration tests #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mildaniel merged 2 commits into from
Jan 14, 2023
Merged

fix: Fix failing esbuild integration tests #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
246cc83
fix: Fix failing esbuild integration tests
mildaniel Jan 13, 2023
db5833b
Replace npm ci with npm install
mildaniel Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/integration/workflows/nodejs_npm_esbuild/test_nodejs_npm_with_esbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def setUp(self):
def _set_esbuild_binary_path(self):
npm = SubprocessNpm(self.osutils)
esbuild_dir = os.path.join(self.TEST_DATA_FOLDER, "esbuild-binary")
npm.run(["ci"], cwd=esbuild_dir)
npm.run(["install"], cwd=esbuild_dir)
self.root_path = npm.run(["root"], cwd=esbuild_dir)
self.binpath = Path(self.root_path, ".bin")

Expand Down Expand Up @@ -169,7 +169,7 @@ def test_bundles_project_without_dependencies(self, runtime):
osutils = OSUtils()
npm = SubprocessNpm(osutils)
esbuild_dir = os.path.join(self.TEST_DATA_FOLDER, "esbuild-binary")
npm.run(["ci"], cwd=esbuild_dir)
npm.run(["install"], cwd=esbuild_dir)
binpath = Path(npm.run(["root"], cwd=esbuild_dir), ".bin")

self.builder.build(
Expand All @@ -195,7 +195,7 @@ def test_builds_project_with_remote_dependencies_without_download_dependencies_w
osutils = OSUtils()
npm = SubprocessNpm(osutils)
esbuild_dir = os.path.join(self.TEST_DATA_FOLDER, "esbuild-binary")
npm.run(["ci"], cwd=esbuild_dir)
npm.run(["install"], cwd=esbuild_dir)
binpath = Path(npm.run(["root"], cwd=esbuild_dir), ".bin")

self.builder.build(
Expand Down