Skip to content

Conversation

@torresxb1
Copy link
Contributor

@torresxb1 torresxb1 commented Feb 15, 2023

Issue #, if available:

Description of changes:
Had previously added test for building in source with esbuild, but now adding a test with local dependency as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@torresxb1 torresxb1 requested a review from a team as a code owner February 15, 2023 21:49
@torresxb1 torresxb1 requested review from hnnasit, mildaniel and mndeveci and removed request for hawflau, lucashuy and mndeveci February 15, 2023 21:50
Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to local invoke to validate the built function?
NVM, I thought this is SAM CLI repo.

@torresxb1 torresxb1 merged commit 88e90e9 into aws:develop Mar 3, 2023
@torresxb1 torresxb1 deleted the esbuild-integ-test-local-deps branch March 3, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants