Skip to content

feat: support banner param for esbuild #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mndeveci wants to merge 2 commits into from
Closed

feat: support banner param for esbuild #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049b49b
feat: support banner param for esbuild
mndeveci Mar 13, 2023
e308aa0
format files
mndeveci Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions aws_lambda_builders/workflows/nodejs_npm_esbuild/esbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,7 @@ def run(self, args, cwd=None):
]

# Multi-value types (--external:axios --external:aws-sdk)
SUPPORTED_ESBUILD_APIS_MULTI_VALUE = [
"external",
"loader",
"out_extension",
]
SUPPORTED_ESBUILD_APIS_MULTI_VALUE = ["external", "loader", "out_extension", "banner"]


class EsbuildCommandBuilder:
Expand Down
10 changes: 9 additions & 1 deletion tests/unit/workflows/nodejs_npm_esbuild/test_esbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,14 @@ def test_builds_args_from_config(self, osutils_mock):

@patch("aws_lambda_builders.workflows.nodejs_npm.utils.OSUtils")
def test_combined_builder_with_dependencies(self, osutils_mock):
bundler_config = {"entry_points": ["x.js"], "loader": [".proto=text", ".json=js"], "format": "esm"}
bundler_config = {
"entry_points": ["x.js"],
"loader": [".proto=text", ".json=js"],
"format": "esm",
"banner": [
"js=\"import { createRequire } from 'module'; const require = createRequire(import.meta.url);\""
],
}
args = (
EsbuildCommandBuilder("scratch", "artifacts", bundler_config, osutils_mock, "")
.build_entry_points()
Expand All @@ -246,6 +253,7 @@ def test_combined_builder_with_dependencies(self, osutils_mock):
"--format=esm",
"--loader:.proto=text",
"--loader:.json=js",
"--banner:js=\"import { createRequire } from 'module'; const require = createRequire(import.meta.url);\"",
],
)

Expand Down