fix: Ignore flags not relevant to esbuild #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
commented
Jun 5, 2023
|
|
||
| # Ignore the values below. These are options that Lambda Builders accepts for | ||
| # Node.js related workflows, but are not relevant to esbuild itself. | ||
| ESBUILD_IGNORE_VALUES = {"use_npm_ci", "entry_points"} |
Contributor
Author
There was a problem hiding this comment.
I explored other ways of ignoring these types of unrelated values, however didn't find anything reliable (e.g. there's no API to use, and parsing the esbuild help text is very complicated). We can go with this solution for now as it fixes the immediate issue, and look for ways of making this more reliable moving forward.
jfuss
approved these changes
Jun 5, 2023
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Change seems reasonable to me.
Are we sure these are the only two (use_npm_ci, entry_points)?
Contributor
Author
Yup, should be just these. |
sriram-mv
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sam-build-images#90
aws/aws-sam-cli#5236
Description of changes:
Since making the change to accept any flags for esbuild, there is an issue with esbuild trying to use flags that are not related to it. This changes forces the esbuild command builder to ignore those unrelated flags.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.