fix: Decoding non-unicode characters raises unhandled exception #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
approved these changes
Oct 9, 2023
sriram-mv
approved these changes
Oct 9, 2023
| import locale | ||
| import logging | ||
|
|
||
| from ...utils import decode |
Contributor
|
LGTM, though there are windows failures that need to be addressed. |
mndeveci
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#548
aws/aws-sam-cli#2317
Description of changes:
There are times when Lambda Builders will attempt to decode command output that contains unsupported characters. In these events, the program will crash with an unhandled exception. Instead, complete the build and log a message explaining that the output couldn't be decoded.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.