Skip to content

Conversation

@sthulb
Copy link
Contributor

@sthulb sthulb commented Jan 3, 2019

Issue #, if available:

Description of changes:
Pins bundled version on AppVeyor.

AppVeyor drops out with:

ERROR:  Error installing bundler:
	The last version of bundler (>= 0) to support your Ruby & RubyGems was 1.17.3. Try installing it with `gem install bundler -v 1.17.3`
	bundler requires RubyGems version >= 3.0.0. The current RubyGems version is 2.7.8. Try 'gem update --system' to update RubyGems itself.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sthulb sthulb changed the title Updates RubyGems in AppVeyor Updates bundler in AppVeyor Jan 3, 2019
This is the max version of bundler we can use with AppVeyors version of rubygems

Initially, I wanted to update rubygems, but that was too slow and increased build times significantly
@jfuss
Copy link
Contributor

jfuss commented Jan 3, 2019

Should we just update RubyGems instead of pinning?

I don't understand ruby enough to understand which is better: @awood45?

@sthulb
Copy link
Contributor Author

sthulb commented Jan 3, 2019

I tried updating rubygems first. It added a considerable amount of time to the build.

@jfuss
Copy link
Contributor

jfuss commented Jan 3, 2019

@sthulb I see. I am ok pinning this. We don't have any min version requirement so this seems fine to pin given the build time.

@jfuss jfuss merged commit 7182b75 into aws:develop Jan 3, 2019
@awood45
Copy link
Contributor

awood45 commented Jan 3, 2019

This approach is reasonable.

@jfuss jfuss mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants