backcompat: cli #85
Merged
backcompat: cli #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make executable_search_paths computable if not specified and add it as `None`. - explicitly check with a test with older RPC version and removal of `executable_search_paths` param.
Contributor
|
Lgtm |
sanathkr
approved these changes
Feb 14, 2019
jfuss
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: make executable_search_paths computable if not specified and add it as
None.explicitly check with a test with older RPC version and removal of
executable_search_pathsparam.This ensures that if the container is upgraded to the latest version of builders, and we build on the container from a older version of SAM CLI, back compat does not break.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.