Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/implement IHttpActivityFeature #1350

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Add/implement IHttpActivityFeature #1350

merged 2 commits into from
Nov 20, 2022

Conversation

brendonparker
Copy link
Contributor

@brendonparker brendonparker commented Oct 30, 2022

Issue #1348

Description of changes:

Add/register/implement IHttpActivityFeature. This is used by the Host in the aspnet plumbing to start/record diagnostic activities, which can then be picked up by OpenTelemetry.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishdhingra ashishdhingra added the feature-request A feature should be added or improved. label Nov 3, 2022
@normj normj changed the base branch from master to dev November 20, 2022 02:11
@normj normj merged commit f51d3fb into aws:dev Nov 20, 2022
@normj
Copy link
Member

normj commented Nov 20, 2022

I merged the PR into dev and it will go out with the next release of the library.

@normj
Copy link
Member

normj commented Dec 7, 2022

Version of 7.3.0 of Amazon.Lambda.AspNetCoreServer and 1.4.0 of Amazon.Lambda.AspNetCoreServer.Hosting have been pushed with this PR. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants