Add common 5xx status codes to HttpResults for Annotations framework #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdhingra
added
bug
normj
requested changes
Feb 13, 2023
There was a problem hiding this comment.
The changes look good but can you add some unit tests here? https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/test/Amazon.Lambda.Annotations.SourceGenerators.Tests/HttpResultsTest.cs
normj
approved these changes
Feb 13, 2023
|
Don't worry about the Source Generator CI failure. That is a permission issue running PRs on branches outside of this repository. |
boblodgett
approved these changes
Feb 13, 2023
|
The PR has been released as part of version 0.12.0 of Amazon.Lambda.Annotations. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1431
Description of changes:
Added return types for HttpResults described in issue. This change adds 500, 502 and 503 errors
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.