Incorrectly using ASCII instead of UTF8 when converting message body to byte[] #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing message body to byte[]
ashishdhingra
approved these changes
Sep 27, 2024
96malhar
approved these changes
Sep 27, 2024
96malhar
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1824
Description of changes:
In a previous update to the library when we switched to using the registered serializer for deserializing message body to the
FromBodytype the code incorrectly converted to a byte array using theASCIIencoding. This PR changes the encoding toUTF8.The changes is all in the
APIGatewaySetupParameters.ttfile. The rest of the PR is updating the version bump to1.5.2and updating the unit test snapshots.Testing
Updated the generated snapshots used in unit tests to confirm we are using UTF8. I also rerun the original issues scenario in Lambda with a built version of the NuGet package and confirmed the correct encoding of the Unicode characters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.