Sync Dev from Master #1876
Merged
Sync Dev from Master #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Support The SnapStart support includes adding a new SnapStart.Registry package for registering and invoking hooks during the SnapStart lifecycle. --------- Co-authored-by: Phil Asmar <phil.asmar@gmail.com> Co-authored-by: Philippe El Asmar <53088140+philasmar@users.noreply.github.com> Co-authored-by: Saksham Bhalla <bhallasaksham@gmail.com> Co-authored-by: Saksham Bhalla <sakshmb@amazon.com> Co-authored-by: Philip Pittle <ppittle@users.noreply.github.com>
boblodgett
reviewed
Nov 19, 2024
| } | ||
| catch (TypeLoadException ex) | ||
| { | ||
| Client.ConsoleLogger.FormattedWriteLine( |
There was a problem hiding this comment.
This doesn't appear to terminate or exit the call which means it will fall through where registry will be null. The following comment says no expection in calling SnapStart hooks but it looks like there could have been an exception still. Is this correct?
There was a problem hiding this comment.
This is correct. We wanted to support users still enabling SnapStart without updating their version of Amazon.Lambda.Core. If they have an older version of Core in the deployment bundle we will get a TypeLoadException when we try to access the registry in it. It is the awkwardness of dependencies in Lambda.
boblodgett
approved these changes
Nov 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sync dev branch with latest commits to master.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.