Revert behavior for non SnapShot scenario to throw an exception when initialize fails #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialization fails
normj
force-pushed
the
normj/runtime-errorhandling
branch
from
adac646 to
efae5c5
Compare
Beau-Gosse-dev
approved these changes
Nov 26, 2024
ppittle
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1881
Description of changes:
As part of the work for SnapStart we need to force an exit quickly if there was a initialization error. That ensured the Lambda service picked up the logs to put in CloudWatch logs. This triggered a refactor that changed the behavior for non SnapStart case to not get an Exception when Lambda functions started the LambdaBootstrap themselves. This PR reverts the behavior for non SnapStart case to ensure the exception is bubbled up to the caller of LambdaBootstrap.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.