Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon.Lambda.RuntimeSupport dll to the output nuget package #1897

Open
wants to merge 3 commits into
base: feature/lambdatesttool-v2
Choose a base branch
from

Conversation

gcbeattyAWS
Copy link

Issue #, if available:

Description of changes:

  1. Add Amazon.Lambda.RuntimeSupport dll to the output nuget package
  2. Add test to verify dll is inside the content folder.

Testing

  1. So far only tested via checking that the files are in the nuget package manually. I still need to test that this dll works by running with the aspire proof of concept.
    Screenshot 2024-12-04 153915

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

</ItemGroup>

<ItemGroup>
<None Include="$(OutputPath)Amazon.Lambda.RuntimeSupport.dll" Pack="true" PackagePath="content" Visible="false" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasnt sure if this needed to be content or lib folder. was seeing this warning when doing pack command

The assembly 'content\Amazon.Lambda.RuntimeSupport.dll' is not inside the 'lib' folder and hence it won't be added as a reference when the package is installed into a project. Move it into the 'lib' folder if it needs to be referenced.

but in our case in we are referencing the dll as part of a command line argument in the aspire proof of concept , so not sure if it really matters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is only adding the current target framework (net8.0) version of RuntimeSupport. I believe we need to add all targets of Runtimesupport. @normj is my assumption correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember he mentioned when he updated the test tool v2 something about to not worry about the other versions. but ill let him confirm

public class PackagingTests
{
[Fact]
public void VerifyPackageContentsHasRuntimeSupport()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this test case but wasnt sure it was overkill or not

</ItemGroup>

<ItemGroup>
<None Include="$(OutputPath)Amazon.Lambda.RuntimeSupport.dll" Pack="true" PackagePath="content" Visible="false" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still need to test end to end with aspire poc if any more (lambda core dlls) are needed or anything else

@gcbeattyAWS gcbeattyAWS changed the title add packaging of runtime Add Amazon.Lambda.RuntimeSupport dll to the output nuget package Dec 17, 2024
@gcbeattyAWS gcbeattyAWS marked this pull request as ready for review December 17, 2024 18:35
Copy link
Contributor

@philasmar philasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is only adding the current target framework (net8.0) version of RuntimeSupport. I believe we need to add all targets of Runtimesupport. @normj is my assumption correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants