Update TestToolv2 Lambda Runtime API for multi function and RequestResponse mode #1912
+321
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
commented
Dec 20, 2024
|
|
||
| if (!string.IsNullOrEmpty(evnt.Response)) | ||
| { | ||
| var responseData = Encoding.UTF8.GetBytes(evnt.Response); |
There was a problem hiding this comment.
I removed the use of using IResult because they were adding another layer of JSON encoding that was altering the JSON sent by the Lambda function.
…ening function and support for RequestResponse invocation type.
normj
force-pushed
the
normj/testtool-vs-add-datastore-manager
branch
from
9403f85 to
79ef0b5
Compare
normj
commented
Dec 20, 2024
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| [assembly: Xunit.CollectionBehavior(DisableTestParallelization = true)] | |||
There was a problem hiding this comment.
Because the unit tests involve setting environment variables for Amazon.Lambda.RuntimeSupport I disabled test parallelization to avoid flakiness running the tests.
philasmar
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated the Lambda Runtime API to partition the events for being processed by function name. That is done by a new
IRuntimeApiDataStoreManagerthat is basically a dictionary ofIRuntimeApiDataStoreper function names.Also the
InvocationTypeon the Lambda invoke method is now honored returning back a response whenInvocationTypeis set toRequestResponse. This required adding aManualResetEventSlimto the queued events to synchronized sending a response back to the caller of the invoke with when the Lambda function reports completion.Work to be done in future PRs to keep this PR small.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.