Lambda blueprints for V4 SDK #2058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update the package references in the Lambda blueprints including updating to V4 of the AWS SDK for .NET. As part of updating I decided it was time to finally remove the VS 2017 and 2019 blueprints since they were very stale and the toolkit doesn't even support those versions of VS.
The PR is 2 commits with the first commit being the delete and the second commit being the package reference update. For reviewing it might be easier to view the second commit.
On the F# blueprints that use the SDK I added
<NoWarn>FS3536</NoWarn>to the project file. TheFS3536warning is getting triggered because in V4 the SDK has static abstract methods on the service interface. My understanding is F# does not want you using interfaces with only static abstract methods for anything other then generic constraints. In our case the service client interface has a both instance methods and the static abstract method. We don't even expect users call the static abstract method as that was added for helping make AWSSDK.Extensions.NETCore.Setup Native AOT compliant.Testing
Ran the build script that instantiates all of the blueprints and compiles the blueprints. I also pointed my VS toolkit to the templates and instantiated a few templates manually and deployed to confirm working. The DetectImage blueprints were the ones with the most SDK usage and I specifically deployed and exercised the code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.