Use the aspnet core logging infrastructure for logging #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asier to suppress these messages.
normj
requested changes
Aug 10, 2018
As pointed out by reviewer (aws#304) this is more appriopriate.
|
Good point. I've fixed that. |
|
@normj Can you please take a peek at this again? Thanks! |
|
The PR looks good and I'm going to merge it in. I'm just trying to finish up another project right now and then I'll get this merged and released. |
|
Thanks for the pull request. I have the change staged in the dev branch to go out with the next release. |
normj
approved these changes
Sep 14, 2018
|
Version 2.1.0 was just released with this pull request. Thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to suppress these messages.
Issue #, if available: None
Description of changes:
Use an ILogger to log messages from APIGatewayProxyFunction. Use
LogDebugsince these messages are really for debugging and not generally useful for a production service.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.