Fixed issue with not handling query string encoding #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng from API Gateway to ASP.NET Core Lambda function
vellozzi
reviewed
Apr 29, 2019
There was a problem hiding this comment.
Is this right?
"API Gateway will encode the values before passing them to the Lambda function and ALB does not. There was a mistake when ALB was added thinking both services send decoded values."
I'm assuming it should read "API Gateway will decode the values..." instead. Otherwise, the code is opposite of the description.
Also, there's a typo in the name of Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/values-get-querystring-apigatway-encoding-request.json.
|
Corrected description of the problem and fixed the typo in all of the test files. |
vellozzi
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed an issue where query string values were not correctly being encoded for requests coming in from API Gateway to ASP.NET Core Lambda functions. This address the following issue #415
This behavior was triggered when Application Load Balancer support was added. API Gateway will decode the values before passing them to the Lambda function and ALB does not decode. There was a mistake when ALB was added thinking both services send decoded values.
The fix is to have API Gateway request UrlEncode values before adding them to the ASP.NET Core request. ASP.NET Core will later UrlDecode the values.
Tests were done by first manually verifying what API Gateway and ALB pass into Lambda functions and then updating the encoding JSON test documents for the unit tests.