Added code to load cookies from HTTPv2 request. #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Sep 4, 2020
|
Hello! Done. |
normj
reviewed
Sep 8, 2020
| @@ -20,7 +20,9 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1'"> | |||
| <PackageReference Include="Microsoft.AspNetCore.All" Version="2.1.5" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.All" Version="2.1.5"><PrivateAssets Condition="'%(PackageReference.Version)' == ''">all</PrivateAssets> | |||
There was a problem hiding this comment.
What is the context of this change?
There was a problem hiding this comment.
Hm. Looks like something VS stuck in there. I'll revert this.
normj
approved these changes
Sep 10, 2020
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or Request:
#713
Description of changes:
This PR changes the behavior of the code that converts API GW events into ASP.NET requests by pulling the cookies from the events'
cookiesproperty into aCookiesheader on the request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.