Wrong struct for IoTCustomAuthorizerRequest

[rittneje]

#67 intended to add the request/response structs for an IoT Core custom authorizer. However, the wrong documention was referenced, so the request structure is completely wrong. The correct structure is documented here: https://docs.aws.amazon.com/iot/latest/developerguide/config-custom-auth.html

Obviously fixing this is technically a breaking change, but I would think that should be acceptable all things considered.

cc @bmoffatt

ETA: The response struct is also wrong.

[ynori7]

I have the feeling that the documentation may be completely unreliable. Is there any way to get it updated? The documentation you linked conflicts with https://docs.aws.amazon.com/iot/latest/apireference/API_TestInvokeAuthorizer.html which is what I used while testing (and it worked). If the testing tool and the real thing really do differ, how does anyone ever test their authorizors before deploying them?

[rittneje]

@ynori7 The documentation you linked is for the test event you can send to test your custom authorizer. It is distinct from the request your lambda actually receives from IoT Core itself. (Again, I don't know why the IoT Core team apparently decided to make two separate structs, as it is abundantly confusing.)

Really the best way to test your authorizer is to actually invoke it via normal means (by connecting to the broker). I don't understand the use of the TestInvokeAuthorizer command.

[ynori7]

@rittneje I can update the models then. I just wonder if it would also make sense to raise a bug for whichever code base the test invoke tool is in because it doesn't seem very useful if you need to use different models for it.

[rittneje]

@ynori7 You could try to raise an issue against the SDK. https://github.com/aws/aws-sdk But really this is an issue with the TestInvokeAuthorizer feature from IoT Core, so you might want to raise a support ticket from your AWS account if possible.

[ynori7]

@rittneje @bmoffatt I opened a PR to correct it. Could you take a look?

[ynori7]

@rittneje Sorry, I missed that you already opened a pull request.