Add S3 test event #163
Merged
Add S3 test event #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
======================================
Coverage 69.8% 69.8%
======================================
Files 18 18
Lines 679 679
======================================
Hits 474 474
Misses 165 165
Partials 40 40Continue to review full report at Codecov.
|
bmoffatt
reviewed
Feb 4, 2019
sample event:
```
{"Service":"Amazon S3","Event":"s3:TestEvent","Time":"2019-02-04T19:34:46.985Z","Bucket":"bmoffatt","RequestId":"7BA1940DC6AF888B","HostId":"q1YDbiaMjllP0m+Lcy6cKKgxNrMLFJ9zCrZUFBqHGTG++0nXvnTDIGC7q2/QPAsJg86E8gI7y9U="}
```
|
I didn't see S3 send the test event to my Lambda function in testing, but could for SQS 🤷♂️ |
|
Right, but the SQS event appears to include this test event so it would be good to just have the def in the library. |
Marchaling -> Marshaling
bmoffatt
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in https://docs.aws.amazon.com/AmazonS3/latest/dev/notification-content-structure.html.
I didn't write a test as they are set up for a 1-1 mapping between event and service. Happy to add one, but it will take some test refactoring and for this simple struct that is never used in production I thought it likely wasn't worth it.