Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #231 -- Updated dependency versions #232

Merged

Conversation

Narendra-Kamath
Copy link
Contributor

It is observed that the dependency github.com/urfave/cli at a release version of v1.22.0 was having an issue (urfave/cli#888). It was due to the some of the dependency issues with cli, v1.22.1 was released with a fix (urfave/cli#887).

The pull request includes the update of the package dependencies being used in the project. Thus being updated with the dependency versions, will not break the following:

go.exe get -u github.com/aws/aws-lambda-go/cmd/build-lambda-zip

Which includes build using latest available updated versions of dependencies. (Ref: https://github.com/aws/aws-lambda-go/blob/master/README.md)

Solves: #231

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files          20       20           
  Lines         677      677           
=======================================
  Hits          504      504           
  Misses        128      128           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4f484...88f12a2. Read the comment docs.

@Narendra-Kamath
Copy link
Contributor Author

@bmoffatt please do review.

@bmoffatt bmoffatt merged commit 68877f4 into aws:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants