Improvements to golint #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 20 20
Lines 681 681
=======================================
Hits 508 508
Misses 128 128
Partials 45 45
Continue to review full report at Codecov.
|
diegobernardes
suggested changes
Oct 22, 2019
Contributor
diegobernardes
left a comment
diegobernardes
left a comment
There was a problem hiding this comment.
@robertoduessmann thanks for this contribution. I found one little typo, after that is fixed, the code can be merged.
Contributor
Author
|
Hey @diegobernardes thanks a lot for catching it, I'm on it 👍 😃 |
diegobernardes
approved these changes
Oct 23, 2019
bmoffatt
approved these changes
Oct 23, 2019
Collaborator
|
Thanks! |
Contributor
Author
|
Thank you guys 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
As reported here https://goreportcard.com/report/github.com/aws/aws-lambda-go#golint the golint of the project currently is 61%.
Description of changes:
As part of the suggestions from the golint, I added comment to methods and structs to explain the context behind the code in order to increase in some percentage the golint coverage from the project.
Once the golint is increased we will be able to add the project to the awesome-go list. I tried some time ago to add the aws-lambda-go there here but was declined because the currently golint coverage of the project is below their standards.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.