Bump AWS Lambda C++ Runtime from v0.2.8 to v0.2.10 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer required by `aws-lambda-cpp`.
By running `./scripts/update-dependencies.sh` from the repository root.
ianyong
force-pushed
the
bump-aws-lambda-cpp
branch
from
10524bb to
dfc42c6
Compare
|
@maxday any chance to review it? |
Author
|
Hi @maxday @godcrampy @briensea, is there anything blocking the merging of this PR? Without the changes in this PR, the RIC cannot be used in Alpine 3.17 and above out of the box. Alpine 3.16 has EOLed more than a year ago on 23 May 2024. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #68, fixes #90.
Description of changes:
The
libexecinfo-devpackage is no longer available in Alpine v3.17:This prevents the AWS Lambda C++ Runtime from being built unless the
libexecinfo-devpackage is installed from Alpine's package repository for v3.16 or earlier (see awslabs/aws-lambda-cpp#124, awslabs/aws-lambda-cpp#186).The dependency on the
libexecinfo-devpackage was made optional in awslabs/aws-lambda-cpp#189 which was released as part of v0.2.9 of the AWS Lambda C++ Runtime. As such, we upgrade the version ofaws-lambda-cppused by the RIC to the latest version v0.2.10 which includes the change.Note that
aws-lambda-cpp-add-xray-response.patchwas left intact and applied viaupdate-dependencies.shbecause the changes are not present upstream (/src/runtime.cpp&/include/aws/lambda-runtime/runtime.h).libexecinfo-devpackage in the Alpine integration tests was removed as it is no longer a required dependency foraws-lambda-cpp.Target (OCI, Managed Runtime, both):
OCI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.