Migrate to poetry for better dependency management #194
Conversation
AntoniaSzecsi
requested review from
maxday,
godcrampy,
PartiallyUntyped and
trivenay
pyproject.toml
Outdated
| "PLR0913", # Too many arguments | ||
| "E722", # Bare except | ||
| "PLW0603", # Global statement | ||
| "UP031", # % formatting vs f-strings | ||
| "E402", # Module import not at top |
There was a problem hiding this comment.
Could you help me understand the reasoning behind ignoring these rules? I'm curious if there's a specific use case or limitation that made this necessary
| @@ -0,0 +1,88 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Here's what's happening: Makefile (a build tool) calls this script (a build tool) which calls poetry (another build tool). This layering feels a bit complex. Do you think there's an opportunity to simplify the flow?
Or could you help me understand why we have this?
There was a problem hiding this comment.
Yes, true, the workflow is a little complex, but the purpose was to make the MakeFile as minimal and simple looking as possible. But surely, we can directly call the poetry from the MakeFile and get rid completely of the dev.py
I used dev.py as there are some github templates with it
|
Summary from yesterday; remove |
* Add docstrings checking with ruff and implement the fixes * Fix build and test invocations of RIE * Format file according to linter requirements * Remove ignore rules and move docstring logic to dev file --------- Co-authored-by: AntoniaSzecsi <lszecsi@amazon.com>
Issue #, if available:
Description of changes:
Target (OCI, Managed Runtime, both):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Summary of the changes:
Migrated to Poetry: Replaced pip-based dependency management with Poetry for better dependency resolution and lock files
Fixed Docker builds and integration tests: Resolved Poetry installation issues and ensuring consistent Python version usage in the docker files.
Migrated from pylint to ruff: Updated linting configuration for faster and easily customisable code analysis.
Created dev.py: Added a development script according to industry templates with clean command structure.
Cleaned setup.py: Reformatted and simplified build configuration for better maintainability.