Remove importlib.metadata dependency #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukanyaHanumanthu
approved these changes
Aug 20, 2021
carlzogh
approved these changes
Aug 20, 2021
DavidCain
added a commit
to DavidCain/aws-lambda-python-runtime-interface-client
that referenced
this pull request
Jul 1, 2022
This should complete a previous attempt to remove dependency on the package, unblocking use of `awslambdaric` in projects that use a newer version of `importlib-metadata`. Version 2 of `importlib-metadata` is reasonably old - version 4.4 is present in Python 3.10 for instance. Motivation for the change ========================= I think issue aws#61 covers it well, but essentially it becomes difficult to use `awslambdaric` in a virtualenv with other dependencies that expect a newer version of `importlib-metadata`: aws#61 `awslambdaric` isn't supposed to need `importlib-metadata` anyway ================================================================= Previous work (in August of 2021, with version 1.2.2) removed all dependency on the `importlib-metadata` package, but accidentally left `importlib-metadata` as a full dependency of this package: - aws#55 Most recent version still has `importlib-metadata` dependency ============================================================= ``` $ pip show awslambdaric Name: awslambdaric Version: 2.0.4 ... Requires: importlib-metadata, simplejson ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove importlib.metadata dependency & introduce
__version__.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.