-
Notifications
You must be signed in to change notification settings - Fork 32
Ruby 3.3.3 default logger 1.6.0 is failing on lambda #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is also happening on Ruby 3.2 |
We hit the same issue. As mentioned above, it is present for both 3.2 and 3.3 runtimes. |
workaround is to downgrade explicitly the logger gem to UPDATE or to logger |
The most recent version of logger (v1.6.1) has resolved this for us where they now guarantee level_override exists |
Is a fix for this still necessary or desired with the latest logger change? |
@mullermp But I think my solution is more safe for the future as it calls super in all code branches in overwritten patch. You can also close it if you would like |
It makes sense to call super as you've done. I'll look this week. |
I've added a solution PR, but maybe issue is needed to be picked up by reviewers?
#32
Problem is made by changes in logger and lambda ruby is changing logger initializer too much
(there is some logic in logger.rb in initializer, which is not best practice maybe :P and it is not backward compatible for initializer function overwrites :D)
The text was updated successfully, but these errors were encountered: