Skip to content

Ruby 3.3.3 default logger 1.6.0 is failing on lambda #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
choosen opened this issue Jul 8, 2024 · 7 comments
Open

Ruby 3.3.3 default logger 1.6.0 is failing on lambda #33

choosen opened this issue Jul 8, 2024 · 7 comments

Comments

@choosen
Copy link
Contributor

choosen commented Jul 8, 2024

I've added a solution PR, but maybe issue is needed to be picked up by reviewers?

#32

Problem is made by changes in logger and lambda ruby is changing logger initializer too much
(there is some logic in logger.rb in initializer, which is not best practice maybe :P and it is not backward compatible for initializer function overwrites :D)

@cgaube
Copy link

cgaube commented Jul 17, 2024

This is also happening on Ruby 3.2

@kminevskiy
Copy link

We hit the same issue. As mentioned above, it is present for both 3.2 and 3.3 runtimes.

@choosen
Copy link
Contributor Author

choosen commented Jul 22, 2024

workaround is to downgrade explicitly the logger gem to ~> 1.5.0 🤔

UPDATE or to logger 1.6.1

@HistoireDeBabar
Copy link

The most recent version of logger (v1.6.1) has resolved this for us where they now guarantee level_override exists

@mullermp
Copy link
Contributor

Is a fix for this still necessary or desired with the latest logger change?

@choosen
Copy link
Contributor Author

choosen commented Feb 25, 2025

@mullermp
It not so much needed as 1.6.1 logger is compatible again.

But I think my solution is more safe for the future as it calls super in all code branches in overwritten patch.

You can also close it if you would like

@mullermp
Copy link
Contributor

It makes sense to call super as you've done. I'll look this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants