Don't Ignore Custom Formatters + Version Bump to 3.1.2 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 4, 2025 14:34
…-interface-client into moehabe/fix_logging
M-Elsaeed
changed the title
maxday
approved these changes
Jun 5, 2025
godcrampy
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We have 2 PRs modifying the logging behavior
#32
#47
Following the first PR, in case the
logdevicewasstdoutorstderr, lambda's custom formatter which we used to assign to@default_formatterwas ignored since we were calling the constructor which restored the@default_formatterto ruby's built in default formatter; HOWEVER, if you passed in a formatter, that will be used.Following the second PR, in case the
logdevicewasstdoutorstderr, the formatter is always set to be lambda's custom formatter.This PR allows custom formatters.
Target (OCI, Managed Runtime, both): Both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.