Skip to content

Commit

Permalink
Add testing
Browse files Browse the repository at this point in the history
  • Loading branch information
justsmth committed Oct 4, 2024
1 parent a4c8807 commit e4a8737
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 6 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -592,3 +592,31 @@ jobs:
working-directory: ./aws-lc-rs
# Rust doc tests dislike dynamic linking
run: cargo careful test --tests --features fips,bindgen

clang-19-bindgen:
if: github.repository_owner == 'aws'
name: Clang 19.1 + bindgen tests
runs-on: macos-14-xlarge
steps:
- uses: actions/checkout@v4
with:
submodules: 'recursive'
- uses: actions/setup-go@v4
with:
go-version: '>=1.18'
- uses: dtolnay/rust-toolchain@master
id: toolchain
with:
toolchain: stable
- run: |
cargo install --force --locked bindgen-cli
brew update
brew uninstall --force llvm
brew install llvm@19
echo 'export PATH="/opt/homebrew/opt/llvm/bin:$PATH"' >> "$GITHUB_ENV"
- name: aws-lc-sys bindgen build
working-directory: ./aws-lc-sys
run: cargo test --features bindgen
- name: aws-lc-fips-sys bindgen build
working-directory: ./aws-lc-fips-sys
run: cargo test --features bindgen
14 changes: 11 additions & 3 deletions aws-lc-fips-sys/builder/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,20 @@ fn is_bindgen_required() -> bool {
bindgen_available!(
fn internal_bindgen_supported() -> bool {
let cv = bindgen::clang_version();
if let Some((major, _)) = cv.parsed {
if let Some((major, minor)) = cv.parsed {
if major >= 19 {
return false;
emit_warning(&format!(
"Clang v{major}.{minor} detected. Will not use internal bindgen."
));
false
} else {
emit_warning(&format!("Clang v{major}.{minor} detected."));
true
}
} else {
emit_warning(&format!("Clang version: {}", cv.full));
true
}
true
}
);

Expand Down
14 changes: 11 additions & 3 deletions aws-lc-sys/builder/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,20 @@ fn is_bindgen_required() -> bool {
bindgen_available!(
fn internal_bindgen_supported() -> bool {
let cv = bindgen::clang_version();
if let Some((major, _)) = cv.parsed {
if let Some((major, minor)) = cv.parsed {
if major >= 19 {
return false;
emit_warning(&format!(
"Clang v{major}.{minor} detected. Will not use internal bindgen."
));
false
} else {
emit_warning(&format!("Clang v{major}.{minor} detected."));
true
}
} else {
emit_warning(&format!("Clang version: {}", cv.full));
true
}
true
}
);

Expand Down

0 comments on commit e4a8737

Please sign in to comment.