-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross build for target x86_64-pc-windows-gnu failed #413
Comments
It looks like the key issue is:
Why was it not found in this build environment? Shouldn't |
After installing
|
Thanks for reporting this build failure. I am able to reproduce it locally. I'm working on diagnosing it now. |
This appears to be related to this issue: https://stackoverflow.com/questions/44382862/how-to-printf-a-size-t-without-warning-in-mingw-w64-gcc-7-1 |
### Issues: * aws/aws-lc-rs#413 ### Description of changes: * Some versions of MinGW complain about use of `z` in a format specification: https://stackoverflow.com/questions/44382862/how-to-printf-a-size-t-without-warning-in-mingw-w64-gcc-7-1 * This problem relates to a claim that the Windows C-Runtime ("msvcrt") only supports C89 format strings. However, this appears to have been addressed by (or before) MSVC 2015: https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-140#size-prefixes-for-printf-and-wprintf-format-type-specifiers ### Testing: With this change I was able to successfully cross-compile to x86_64-pc-windows-gnu: ``` ❯ cross build -p aws-lc-rs --features bindgen --target x86_64-pc-windows-gnu ... Compiling aws-lc-sys v0.16.0 (/Users/justsmth/repos/aws-lc-rs/aws-lc-sys) warning: aws-lc-sys@0.16.0: Generating bindings - internal bindgen. Platform: x86_64-pc-windows-gnu Compiling aws-lc-rs v1.7.1 (/Users/justsmth/repos/aws-lc-rs/aws-lc-rs) Finished dev [unoptimized + debuginfo] target(s) in 29.94s ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
As of our v1.7.1 release, the cross build for |
I fixed the runtime issue by using the latest version of Wine (9.0) into the container: https://github.com/aws/aws-lc-rs/actions/runs/8971663108/job/24637916198. See PR: #414. Please let us know about any other build issues you find. Thanks! |
Problem:
Trying to cross build from Linux host with cross:
Relevant details
aws-lc-sys v0.15.0 (on crates.io).
System information: for linux, below info can be collected by running
uname -srvmp
Build log:
"bindgen"
inCargo.toml
"bindgen"
inCargo.toml
The text was updated successfully, but these errors were encountered: