Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Step 1 - move "padded" cipher implementation to sub-module #408

Merged
merged 7 commits into from
May 7, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 25, 2024

Description of changes:

  • Without changing the public API, this change moves much of the implementation for padded block ciphers to its own sub-module.
  • Prepare for the use of EVP_CIPHER_CTX for streaming operations:
    • Refactor of UnboundCipherKey to delay the creation of the SymmetricCipherKey (or EVP_CIPHER_CTX until it's "bound" to an operation-specific key.
  • This is the start of the work toward supporting for a "streaming" cipher modality (re: Support streaming API for CBC #396).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner April 25, 2024 13:16
@justsmth justsmth force-pushed the refactor-ciphers branch 4 times, most recently from d248443 to 1e50e90 Compare April 25, 2024 15:26
skmcgrail
skmcgrail previously approved these changes Apr 25, 2024
@justsmth
Copy link
Contributor Author

API-diff now confirms that no API has changed: https://github.com/aws/aws-lc-rs/actions/runs/8847917376/job/24296754264?pr=408

 Removed items from the public API
=================================
(none)
Changed items in the public API
===============================
(none)
Added items to the public API
=============================
(none)

@justsmth justsmth force-pushed the refactor-ciphers branch from c1181b3 to 1a19199 Compare May 7, 2024 13:48
@skmcgrail skmcgrail self-requested a review May 7, 2024 17:44
@justsmth justsmth merged commit d6ca84e into aws:main May 7, 2024
184 checks passed
@justsmth justsmth deleted the refactor-ciphers branch May 7, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants