Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test agreement with randomly generated keys #464

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Tests for "agreement" were largely using known test values or "KATs". This change adds a test using randomly generated keys.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner July 17, 2024 18:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (c358484) to head (fc4f0c0).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   95.80%   92.86%   -2.94%     
==========================================
  Files          61       62       +1     
  Lines        8143     8663     +520     
  Branches        0     8663    +8663     
==========================================
+ Hits         7801     8045     +244     
- Misses        342      362      +20     
- Partials        0      256     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth mentioned this pull request Aug 2, 2024
@justsmth justsmth merged commit 3d028a9 into aws:main Aug 15, 2024
189 of 195 checks passed
@justsmth justsmth deleted the more-agreement-tests branch August 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants