Drop unused zeroize_derive feature dependency
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be unused, and has the effect of removing several large proc macro dependencies from the dependency tree: ``` --- before 2024-07-29 11:07:47.128726312 +0100 +++ after 2024-07-29 11:08:01.911637253 +0100 @@ -24,15 +24,6 @@ ├── paste v1.0.15 (proc-macro) ├── untrusted v0.7.1 └── zeroize v1.8.1 - └── zeroize_derive v1.4.2 (proc-macro) - ├── proc-macro2 v1.0.86 - │ └── unicode-ident v1.0.12 - ├── quote v1.0.36 - │ └── proc-macro2 v1.0.86 (*) - └── syn v2.0.72 - ├── proc-macro2 v1.0.86 (*) - ├── quote v1.0.36 (*) - └── unicode-ident v1.0.12 ``` According to `cargo build --timings` the eliminated dependencies account for 3.95s of the build time, which compares unfavourably with the entire aws-lc-sys build time (5.75s).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 95.80% 92.83% -2.97%
==========================================
Files 61 62 +1
Lines 8143 8626 +483
Branches 0 8626 +8626
==========================================
+ Hits 7801 8008 +207
- Misses 342 362 +20
- Partials 0 256 +256 ☔ View full report in Codecov by Sentry. |
Closed
skmcgrail
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be unused, and has the effect of removing several large proc macro dependencies from the dependency tree:
According to
cargo build --timingsthe eliminated dependencies account for 3.95s of the build time, which compares unfavourably with the entire aws-lc-sys build time (5.75s).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.